Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimUtils: fix requiredPlugins #53113

Merged
merged 2 commits into from Dec 31, 2018
Merged

vimUtils: fix requiredPlugins #53113

merged 2 commits into from Dec 31, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 31, 2018 •
edited

Motivation for this change

I broke this in #52767 and didn't notice because I only tested with vim and requiredPlugins is only used by neovim. This would break setups that use string-plugins (like pathogen) with neovim.

Reported in #52767 (comment) by @disassembler.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau mentioned this pull request Dec 31, 2018
Merged
10 tasks
@timokau
Copy link
Member Author

timokau commented Dec 31, 2018

@GrahamcOfBorg build vimPlugins.test_nvim_with_vim_nix_using_pathogen

@FRidh FRidh mentioned this pull request Dec 31, 2018
Closed
@timokau
vimUtils: fix requiredPlugins
093cfde 
I broke this in NixOS#52767 and didn't notice because I only tested with vim
and `requiredPlugins` is only used by neovim. This would break setups
that use string-plugins (like pathogen) with neovim.
@timokau
Copy link
Member Author

timokau commented Dec 31, 2018

Forgot to stage one line.
@GrahamcOfBorg build vimPlugins.test_nvim_with_vim_nix_using_pathogen

@timokau
Copy link
Member Author

timokau commented Dec 31, 2018

@GrahamcOfBorg build vimUtils.test_nvim_with_vim_nix_using_pathogen

Not vimPlugins...

@timokau
neovim: mark as broken for aarch64
d9d9ac9 
Has always been broken.
@timokau
Copy link
Member Author

timokau commented Dec 31, 2018

Not really related but the neovim aarch64 build is failing and apparently has always been failing, so I marked it as broken.

@GrahamcOfBorg build vimUtils.test_nvim_with_vim_nix_using_pathogen

@timokau timokau merged commit 4257504 into NixOS:master Dec 31, 2018
@timokau timokau deleted the neovim-requiredPlugins-fix branch December 31, 2018 10:45
@timokau timokau mentioned this pull request Dec 31, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg