New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc: 7.3 -> 7.4 #53057
gcc: 7.3 -> 7.4 #53057
Conversation
Current system built and booted with this, FWIW, haven't seen any new failures in deployments (but haven't done the heavier testing that might be warranted). In an attempt to investigate the ICE w/LLVM previously encountered (reliably, on multiple machines), I rebuilt everything entirely from bootstrap binaries... and have yet to see the error. This is great except this was using the revision that was causing problems before-- so I'm not quite sure what to conclude. "yet" :). @vcunat the build you linked is green-- presumably it failed previously but succeeded when a rebuild was attempted? AFAIK our current gcc 7.3 does not randomly ICE, so sorting this out seems like a blocker (certainly without a better reason than "latest greatest" for moving to 7.4 😸 ). Hopefully a minor issue that stems from a common source (wishful thinking perhaps, but here's hoping!). I'll go find the exact error I ran into, do you have the one for go (linked hydra build) or others? |
Uh, no, I posted a wrong link. (My clipboard workflow is flaky.) This one, also edited above; I did reproduce it reliably. |
That appears to be using gcc 7.3, are you seeing it with gcc 7.4 as well? |
I meant the latter (in your parentheses). The same change didn't cause the segfault when picked to 18.09. I haven't tried other experiments around it. Anyway, by default I'd trust that gcc minor updates fix more issues than they introduce. |
Agreed! And okay great, that makes sense now re:failures. Think this is ready for staging, then! |
Woohoo, thanks! ❤️ |
Weird, the
on the third attempt my |
https://gcc.gnu.org/gcc-7/changes.html
Motivation for this change
Revisiting previous update PR, #51633 . GitHub isn't letting me reopen (since branch was recreated or force-pushed, apparently, which are both true) so making new PR for this.
Previously observed ICE re:LLVM7 no longer occurs as tested by myself and @vcunat (not using this exact commit however). I'm building system with this-- which has been chugging away all afternoon-- which is only to help ensure not entirely broken ;). Testing help/jobset/thoughts appreciated :).
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)