Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: 7.3 -> 7.4 #53057

Merged
merged 1 commit into from Dec 31, 2018
Merged

gcc: 7.3 -> 7.4 #53057

merged 1 commit into from Dec 31, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 30, 2018

https://gcc.gnu.org/gcc-7/changes.html

Motivation for this change

Revisiting previous update PR, #51633 . GitHub isn't letting me reopen (since branch was recreated or force-pushed, apparently, which are both true) so making new PR for this.

Previously observed ICE re:LLVM7 no longer occurs as tested by myself and @vcunat (not using this exact commit however). I'm building system with this-- which has been chugging away all afternoon-- which is only to help ensure not entirely broken ;). Testing help/jobset/thoughts appreciated :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Dec 30, 2018

I suppose ICE may just (dis)appear on rebuilds more or less randomly, e.g. now I got this one this one.

@dtzWill
Copy link
Member Author

dtzWill commented Dec 30, 2018

Current system built and booted with this, FWIW, haven't seen any new failures in deployments (but haven't done the heavier testing that might be warranted).

In an attempt to investigate the ICE w/LLVM previously encountered (reliably, on multiple machines), I rebuilt everything entirely from bootstrap binaries... and have yet to see the error. This is great except this was using the revision that was causing problems before-- so I'm not quite sure what to conclude. "yet" :).

@vcunat the build you linked is green-- presumably it failed previously but succeeded when a rebuild was attempted?

AFAIK our current gcc 7.3 does not randomly ICE, so sorting this out seems like a blocker (certainly without a better reason than "latest greatest" for moving to 7.4 😸 ). Hopefully a minor issue that stems from a common source (wishful thinking perhaps, but here's hoping!). I'll go find the exact error I ran into, do you have the one for go (linked hydra build) or others?

@vcunat
Copy link
Member

vcunat commented Dec 31, 2018

the build you linked is green

Uh, no, I posted a wrong link. (My clipboard workflow is flaky.) This one, also edited above; I did reproduce it reliably.

@dtzWill
Copy link
Member Author

dtzWill commented Dec 31, 2018

That appears to be using gcc 7.3, are you seeing it with gcc 7.4 as well?
(or is that evidence that apparently our compiler segfaults "randomly" already, regardless of 7.3 vs 7.4? :P)

@vcunat
Copy link
Member

vcunat commented Dec 31, 2018

I meant the latter (in your parentheses). The same change didn't cause the segfault when picked to 18.09. I haven't tried other experiments around it.

Anyway, by default I'd trust that gcc minor updates fix more issues than they introduce.

@dtzWill
Copy link
Member Author

dtzWill commented Dec 31, 2018

Anyway, by default I'd trust that gcc minor updates fix more issues than they introduce.

Agreed! And okay great, that makes sense now re:failures.

Think this is ready for staging, then!

@vcunat vcunat merged commit ee25d91 into NixOS:staging Dec 31, 2018
vcunat added a commit that referenced this pull request Dec 31, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Dec 31, 2018

Woohoo, thanks! ❤️

@dtzWill dtzWill deleted the update/gcc-7.4.0 branch December 31, 2018 12:51
@vcunat
Copy link
Member

vcunat commented Dec 31, 2018

Weird, the hydra machine on hydra.nixos.org got a hash error, twice in a row:

fixed-output derivation produced path '/nix/store/zgx1sjrjlkw182ria8hl19zvc48v7hq9-gcc-7.4.0.tar.xz' with sha256 hash '1v73c16n8k2zig4rsnrh2shnknn7yxfwma5bqrb8lfbs3hiyqjv8' instead of the expected hash '0lgy170b0pp60j9cczqkmaqyjjb584vfamj4c30swd7k0j6y5pgd'

on the third attempt my t4a machine got the job and succeeded (in a rather different physical location). Perhaps some mirror is bad and thus some locations consistently get a bad result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants