Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pysnmp: add missing dep on pycryptodomex #53103

Merged
merged 1 commit into from Jan 3, 2019
Merged

pysnmp: add missing dep on pycryptodomex #53103

merged 1 commit into from Jan 3, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 31, 2018

Motivation for this change

Fixes build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner December 31, 2018 04:15
@dotlambda
Copy link
Member

pycrypto can be dropped: https://github.com/etingof/pysnmp/blob/v4.4.6/requirements.txt

@FRidh
Copy link
Member

FRidh commented Dec 31, 2018

squash

@dtzWill
pysnmp: add missing dep on pycryptodome, fix build
d1d5c30 
pycrypto is no longer needed, so remove.
@FRidh
Copy link
Member

FRidh commented Jan 3, 2019

@GrahamcOfBorg build pythonPackages.pysnmp python3Packages.pysnmp

@Mic92 Mic92 merged commit 7b31311 into NixOS:master Jan 3, 2019
@FRidh FRidh mentioned this pull request Jan 4, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @dotlambda @FRidh @Mic92 @GrahamcOfBorg