Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: Fix update script #53081

Merged
merged 1 commit into from Dec 30, 2018
Merged

vimPlugins: Fix update script #53081

merged 1 commit into from Dec 30, 2018

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

#52767 broke update.py script and it was not addressed in the follow-up #53071
Looks like @timokau updated generated.nix file by hand and forgot to change respective lines in update.py

Also updated plugins while at it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

cc @Mic92

@rvolosatovs rvolosatovs mentioned this pull request Dec 30, 2018
Closed
10 tasks
@timokau
Copy link
Member

timokau commented Dec 30, 2018

Looks like @timokau updated generated.nix file by hand and forgot to change respective lines in update.py

Right, I manually edited it "just for a quick prototype" and then of course forgot about it. Sorry about that and thank you for fixing it.

@timokau
Copy link
Member

timokau commented Dec 30, 2018

@GrahamcOfBorg build vimPlugins.vim-nix

@timokau timokau merged commit f8ff164 into NixOS:master Dec 30, 2018
@rvolosatovs rvolosatovs deleted the fix/vim-plugins branch December 30, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @timokau @GrahamcOfBorg