Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hub: 2.6.1 -> 2.7.0 #53058

Merged
merged 1 commit into from Dec 30, 2018
Merged

hub: 2.6.1 -> 2.7.0 #53058

merged 1 commit into from Dec 30, 2018

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Dec 30, 2018

  • [.] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • [.] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [.] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [.] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [.] Assured whether relevant documentation is up to date
  • [.] Fits CONTRIBUTING.md.

hub: 2.6.1 -> 2.7.0
ce8d1f7 
In addition of bumping version, install bash-completion script in a way,
suitable for autoloading.
@hedning hedning changed the title ###### Things done hub: 2.6.1 -> 2.7.0 Dec 30, 2018
@worldofpeace
Copy link
Contributor

Looks good, I believe that's the correct way to install the bash completion. It's done this way in other distros as well.

@worldofpeace worldofpeace merged commit 77b6eed into NixOS:master Dec 30, 2018
@KAction KAction deleted the hub-2.7.0 branch October 29, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KAction @worldofpeace @GrahamcOfBorg