Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kcharselect: initial packaging #53059

Merged
merged 2 commits into from Jan 4, 2019
Merged

kcharselect: initial packaging #53059

merged 2 commits into from Jan 4, 2019

Conversation

schmittlauch
Copy link
Member

Motivation for this change

The util kcharselect is a very useful helper for inserting special characters.

Things done
  • packaged kcharselect
  • added myself to maintainers list
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch schmittlauch mentioned this pull request Dec 30, 2018
Closed
10 tasks
@infinisil
Copy link
Member

While I can query info for specific characters, having more than one of them in the search bar results in no results for me. Does this work for you?

I do get a lot of (non-fatal) warnings on the terminal, not sure if they're relevant:

$ result/bin/kcharselect
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
Icon theme "breeze" not found.
Icon theme "breeze" not found.
Error: standard icon theme "breeze" not found!
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified

ttuegel
ttuegel requested changes Dec 31, 2018
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Nix expression looks good. The commit which adds the package should have the message

kcharselect: init at 18.12.0

@schmittlauch
kcharselect: init at 18.12.0
ec0eaca 
Packaging `kcharselect` because a KDE tool for inserting special
characters is very useful.
@schmittlauch
Copy link
Member Author

@ttuegel done. I also did some minor additional fixes (license, parallel building)

@infinisil
Copy link
Member

Can you answer my question @schmittlauch ?

@schmittlauch
Copy link
Member Author

@infinisil Sure, sorry I was busy.
I don't get any of these warnings in my build, so probably the environment you're running it from is relevant. Are you running it from a GTK session (Gnome, LXDE, …)?
I myself am running it from a Plasma session.

@infinisil
Copy link
Member

Well, you didn't answer my question :P, I asked:

While I can query info for specific characters, having more than one of them in the search bar results in no results for me. Does this work for you?

(I'm running from just xmonad)

@schmittlauch
Copy link
Member Author

@infinisil Yes, it works for me. Interestingly, only certain multiple-character strings yield results: Whil no doesn't show anything, non does.
screenshot of kcharselect, searching for non

@infinisil
Copy link
Member

Ah thanks. Yeah "non" doesn't return any results for me. There probably is some impurity there somewhere.

@Mic92 Mic92 merged commit fdb148f into NixOS:master Jan 4, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 4, 2019

@infinisil you need to install it in your profile like any other qt application unfortunately. Worked then for me.

@schmittlauch
Copy link
Member Author

you need to install it in your profile like any other qt application unfortunately. Worked then for me.

Why is this the case again? Interestingly it also worked for me (from a Plasma session) when just running the build result directly.

@Mic92
Copy link
Member

Mic92 commented Jan 4, 2019

@schmittlauch I assume the qt/kde plugins where installed in your profile already. There is a pr that tries to address this impurity: #44047

@schmittlauch schmittlauch mentioned this pull request Jan 5, 2019
Merged
10 tasks
@schmittlauch
Copy link
Member Author

backport: #53461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel requested changes

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@schmittlauch @infinisil @Mic92 @ttuegel @GrahamcOfBorg