Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.scat: fix build #53070

Merged
merged 1 commit into from Feb 9, 2019
Merged

haskellPackages.scat: fix build #53070

merged 1 commit into from Feb 9, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 30, 2018

Motivation for this change

The package stopped building when base has been update to 4.11, since 18.09.
Since the maintainer is not responding I'd like to apply the patch here. I also have a backport to
the stable branch ready.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Is this still needed on master?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 9, 2019

Yes, it is. I have fixed the conflict.

@matthewbauer matthewbauer merged commit 29dc71c into NixOS:master Feb 9, 2019
@rnhmjoj rnhmjoj deleted the scat-master branch February 23, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @matthewbauer @GrahamcOfBorg