Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish: do not use internal wcwidth #53069

Merged
merged 1 commit into from Dec 30, 2018
Merged

fish: do not use internal wcwidth #53069

merged 1 commit into from Dec 30, 2018

Conversation

gebner
Copy link
Member

@gebner gebner commented Dec 30, 2018

Motivation for this change

Disables the internal wcwidth implementation of fish. This is important when typing characters such as ⚡ (U+26A1 HIGH VOLTAGE SIGN), otherwise fish computes a different character width than the terminal. See fish-shell/fish-shell#4816 and #53022 (comment)

Before (comparison with alacritty):
fish-before

After:
fish-after

cc @jtojnar @adisbladis @ocharles

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner
fish: do not use internal wcwidth
68076b7 
This is important when typing characters such as ⚡(U+26A1 HIGH VOLTAGE
SIGN), otherwise fish computes a different character width than the
terminal.  See fish-shell/fish-shell#4816
@gebner gebner mentioned this pull request Dec 30, 2018
Merged
10 tasks
@adisbladis
Copy link
Member

@GrahamcOfBorg build fish

@adisbladis adisbladis merged commit 5682bc9 into NixOS:master Dec 30, 2018
@glasserc glasserc mentioned this pull request Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gebner @adisbladis @GrahamcOfBorg