Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sam-cli: 0.5.0 > 0.10.0 #53099

Closed
wants to merge 1 commit into from
Closed

aws-sam-cli: 0.5.0 > 0.10.0 #53099

wants to merge 1 commit into from

Conversation

jnsaff
Copy link
Contributor

@jnsaff jnsaff commented Dec 31, 2018

Motivation for this change

Upgrades aws-sam-cli python program, as this is needed for the Jetbrains plugins to work.

This merge will fail until the following PR's are merged:
#53094
#53095
#53097
#53098

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

@jnsaff Any chance you're gonna add the required packages to this PR?

@dhl
Copy link
Contributor

dhl commented Apr 8, 2019

Didn't realize @jnsaff already opened a PR for aws-sam-cli...

I have opened #59174, and all the dependencies for 0.14.2 have been merged.

@Ma27
Copy link
Member

Ma27 commented Apr 8, 2019

Closing. #59174 updates to a more recent version.

@Ma27 Ma27 closed this Apr 8, 2019
@jnsaff
Copy link
Contributor Author

jnsaff commented Apr 8, 2019

Hi, sorry about all of this. I created the PR’s for all deps and this remembering (apparently incorrectly) to have them separate, which was not the case. And then life happened and these were left dangling. Sorry about this, either close this one, amend this PR or by the end of this week I could fix mine as well.

Sorry again for this delay on my part!

@dhl
Copy link
Contributor

dhl commented Apr 8, 2019

I just happen to need the SAM CLI for some small experiments with lambda and Rust and managed to squeezed some time out to do it :-)

Will make sure to do a PR search next time before packaging so there's no duplicated effort.

Thanks again @jnsaff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants