Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsv: init at 0.9-1 #53101

Merged
merged 1 commit into from Dec 31, 2018
Merged

fsv: init at 0.9-1 #53101

merged 1 commit into from Dec 31, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 31, 2018

Motivation for this change

I just rewatched Jurassic Park and needed to try this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Dec 31, 2018 •
edited

Easy but important to fix: meta.platform => meta.platforms

EDIT: omg best program ever thank you ;) 😁

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 31, 2018

Thank you, fixed.

@dtzWill dtzWill merged commit 290425b into NixOS:master Dec 31, 2018
@dtzWill
Copy link
Member

dtzWill commented Dec 31, 2018

Thanks!

@rnhmjoj rnhmjoj deleted the fsv branch February 23, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @dtzWill @GrahamcOfBorg