Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trilium: init at 0.26.1 #53088

Merged
merged 1 commit into from Jan 2, 2019
Merged

trilium: init at 0.26.1 #53088

merged 1 commit into from Jan 2, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 30, 2018

Motivation for this change

Closes #51355.

Building from source would be better,
but looks to require significant effort at best.

Until a brave hero overcomes this fearsome challenge
patching up the binary isn't too bad
and has worked well enough for at least
light use by myself and another user
over the past few weeks.

Aspiring heroes should note this is low-glory
and are encouraged to apply themselves elsewhere instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emmanuelrosa
Copy link
Contributor

Works with Nixpkgs on Xubuntu as well 👍

@dtzWill dtzWill merged commit 0d75d67 into NixOS:master Jan 2, 2019
@dtzWill dtzWill deleted the feature/trilium branch January 2, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants