Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix editor ground #336

Merged
merged 3 commits into from
Dec 31, 2018
Merged

fix editor ground #336

merged 3 commits into from
Dec 31, 2018

Conversation

Sigma88
Copy link
Contributor

@Sigma88 Sigma88 commented Dec 17, 2018

I left this as a pull request since it is a pretty substantial change and I'm not sure you agree it is needed

these changes fix the recoloring of ground in the editor scenes

it will work automatically without the need of user input, but it allows for a certain degree of customization that was lacking before.

@Sigma88
Copy link
Contributor Author

Sigma88 commented Dec 17, 2018

I called the branch noLinq because I used for loops rather than foreach

If you prefere having foreach loops rather than for let me know and I will change it back

@Sigma88
Copy link
Contributor Author

Sigma88 commented Dec 18, 2018

I was playing around with Kerbal Konstructs and noticed that this method fails if KK is installed

@GER-Space does KK change the name of some materials used in the space center?

EDIT: btw, the old way to target materials by using "material.color" is still working fine, so I guess we could still use that method

EDIT2:
for reference, the previous way to target materials was:

// Old way, works fine with KK
if (material.color.ToString() == new Color(0.640f, 0.728f, 0.171f, 0.729f).ToString())

while the new way is:

// New way, does not work with KK
if (material.name == "ksc_exterior_terrain_grass_02")

@GER-Space
Copy link

KK should not alter the ksc buildings, but any instances placed of the buildings can have new gras textures.
Is there a easy way to recreate that error, so I can debug this?
Sorry I'm a kopernicus noop.

@Sigma88
Copy link
Contributor Author

Sigma88 commented Dec 19, 2018

I will take a closer look and let you know what really happens

for now I don't think any actions are needed since we still have a way to make it work

@StollD
Copy link
Member

StollD commented Dec 30, 2018

Is this ready to be merged? Or do you still want to make changes / test things?

Sorry, something went wrong.

@Sigma88
Copy link
Contributor Author

Sigma88 commented Dec 31, 2018

I think this is ready to be merged

Sorry, something went wrong.

@StollD StollD merged commit b4b2073 into master Dec 31, 2018
@Sigma88 Sigma88 deleted the noLinq branch May 14, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants