Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gzip: 1.9 -> 1.10 #53091

Merged
merged 1 commit into from Dec 31, 2018
Merged

gzip: 1.9 -> 1.10 #53091

merged 1 commit into from Dec 31, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 30, 2018

Motivation for this change

https://savannah.gnu.org/forum/forum.php?forum_id=9339

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Have not built many things with this ("yet"), but don't expect any problems.

@vcunat
Copy link
Member

vcunat commented Dec 31, 2018

As a reminder, even regular files will use null timestamps after the year 2106 [...]

We should start getting ready ;-)

vcunat
vcunat approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NEWS seem very safe. I believe we can stage optimistically, without that much testing.

vcunat
vcunat reviewed Dec 31, 2018
View reviewed changes
pkgs/tools/compression/gzip/default.nix
# In stdenv-linux, prevent a dependency on bootstrap-tools.
makeFlags = "SHELL=/bin/sh GREP=grep";

doCheck = false; # fails
Copy link
Member

@vcunat vcunat Dec 31, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line might perhaps serve as documentation why checks aren't done, but no strong opinion from men on that. EDIT: we can add "pure" comments any time later.

@vcunat vcunat merged commit 06dc418 into NixOS:staging Dec 31, 2018
vcunat added a commit that referenced this pull request Dec 31, 2018
@vcunat
Merge #53091: gzip: 1.9 -> 1.10 (into staging)
6af68f6
@dtzWill dtzWill deleted the update/gzip-1.10 branch December 31, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @vcunat @GrahamcOfBorg