Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce.xfce4-timer-plugin: fix description and add longDescription #53076

Closed
wants to merge 1 commit into from

Conversation

hoijui
Copy link
Contributor

@hoijui hoijui commented Dec 30, 2018

the package description seems to have been copy pasted from an other plugin

Motivation for this change

package description was wrong

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

seems to have been copy pasted fro man other plugin and not adjusted
@worldofpeace
Copy link
Contributor

@hoijui Merged in 0fbaf96

Though this is without the longDescription as I feel that's more of a description of usage, and not just a longer description. Plus other plugins didn't have a longDescription.

Thanks for the fix ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants