Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimUtils.buildVimPlugin: fix helptag generation #53071

Merged
merged 1 commit into from Dec 30, 2018
Merged

vimUtils.buildVimPlugin: fix helptag generation #53071

merged 1 commit into from Dec 30, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 30, 2018

Motivation for this change

I messed that up in my refactoring in #52767, since I moved the relevant
bash code out of a function and failed to adjust the shell variable
name. Now the plugin build will fail loudly when help tag generation
fails to make sure this doesn't happen again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
vimUtils.buildVimPlugin: fix helptag generation
e88b65a 
I messed that up in my refactoring in NixOS#52767, since I moved the relevant
bash code out of a function and failed to adjust the shell variable
name. Now the plugin build will fail loudly when help tag generation
fails to make sure this doesn't happen again.
@timokau
Copy link
Member Author

timokau commented Dec 30, 2018

@GrahamcOfBorg build vim-nix

@timokau
Copy link
Member Author

timokau commented Dec 30, 2018

@GrahamcOfBorg build vimPlugins.vim-nix

@timokau timokau merged commit 30ff3e0 into NixOS:master Dec 30, 2018
@timokau timokau deleted the vim-helptags-fix branch December 30, 2018 11:22
@rvolosatovs rvolosatovs mentioned this pull request Dec 30, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg