Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] dropbox: 55.4.171 -> 63.4.107 #53102

Merged
merged 1 commit into from Jan 2, 2019
Merged

[18.09] dropbox: 55.4.171 -> 63.4.107 #53102

merged 1 commit into from Jan 2, 2019

Conversation

talw
Copy link
Contributor

@talw talw commented Dec 31, 2018

Motivation for this change

Dropbox version is too old. Cannot finish account linking when running setup for the first time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions <- Debian Stretch
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

worldofpeace commented Dec 31, 2018 •
edited

@talw Shouldn't this be a backport of #53062 d5dbfad?

See: https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches

Though I don't think you'll need to supply a reason in msg for this.

@talw
Copy link
Contributor Author

talw commented Jan 2, 2019 •
edited

@talw Shouldn't this be a backport of #53062 d5dbfad?

See: https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches

Though I don't think you'll need to supply a reason in msg for this.

@worldofpeace You are absolutely correct. Excuse my mistake.

I will modify the commit. Let me know if it does not look OK.

Thanks!

@talw
dropbox: 55.4.171 -> 63.4.107 (NixOS#53062)
a3410cf 
Dropbox version 55.4.171 is too old which results in an error when doing
the initial account linking.

(cherry picked from commit d5dbfad)
Reason: To have a usable dropbox package for the next release.
@talw talw closed this Jan 2, 2019
@talw talw reopened this Jan 2, 2019
@worldofpeace
Copy link
Contributor

@worldofpeace You are absolutely correct. Excuse my mistake.

Mistakes are just learning opportunities 😄

I also like to add [18.09] to the beginning of the pr title.
That way reviewers can know at a glance where this change is going.

Aside from that, this looks good and is needed in 18.09.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build dropbox

worldofpeace
worldofpeace approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested execution in a vm and it seemed fine. Going for it.

@worldofpeace worldofpeace merged commit ce5bbb9 into NixOS:release-18.09 Jan 2, 2019
@talw talw changed the title dropbox: 55.4.171 -> 63.4.107 [18.09] dropbox: 55.4.171 -> 63.4.107 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talw @worldofpeace @GrahamcOfBorg