New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuse: allow user configuration of fuse.conf #53074
Conversation
Doesn't fuse read /etc/fuse.conf, the system-wide config file? What are the consequences of defaulting to user allow other? |
I'm really not sure. I don't have an /etc/fuse.conf. sean@akita ~> fuse-overlayfs -o lowerdir=/lower -o upperdir=/upper -o workdir=/work /merged
UID=unchanged
GID=unchanged
UPPERDIR=/upper
WORKDIR=/work
LOWERDIR=/lower
MOUNTPOINT=/merged
fusermount3: option allow_other only allowed if 'user_allow_other' is set in /nix/store/mg0gkrvxyl640abb4v961b8ggrzn4vaq-fuse-3.2.6/etc/fuse.conf
fuse-overlayfs: cannot mount: Operation not permitted It would be nice to find out where this fuse.conf is coming from.
This could be debated but my thought is that most fuse mounts are done within a directory that restricts read access to the mounting user (namely the user's home directory). |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-december/1711/9 |
8123724
to
e24940d
Compare
@bjornfor I changed |
@furrycatherder thanks for this PR it would do the job but unfortunately I have to close it in favor of #59043. The advantage of the approach in #59043 is that it does not require a rebuild of |
@primeos Thanks for the feedback. Any solution works for me. :) |
Motivation for this change
#53072 requires user_allow_other in fuse.conf to work, this PR makes it user configurable.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)