Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropbox: 55.4.171 -> 63.4.107 #53062

Merged
merged 1 commit into from Dec 30, 2018
Merged

dropbox: 55.4.171 -> 63.4.107 #53062

merged 1 commit into from Dec 30, 2018

Conversation

talw
Copy link
Contributor

@talw talw commented Dec 30, 2018 •
edited

Motivation for this change

Current Dropbox version is too old. When installing it and linking your
account there is an error message from Dropbox saying the version is too old, prevents
the client from starting.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
      • Debian Stretch
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • No such tests found.
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
    • Got a "Nothing changed" output
  • Tested execution of all binary files (usually in ./result/bin/)
    • Tested the executable by using Dropbox and syncing.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • Before and after sizes were identical.
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Dec 30, 2018

Thanks for fixing this. Would you mind also creating a PR against the release-18.09 branch?

@timokau timokau merged commit d5dbfad into NixOS:master Dec 30, 2018
@talw
Copy link
Contributor Author

talw commented Dec 31, 2018

Thanks for fixing this. Would you mind also creating a PR against the release-18.09 branch?

Will do!

@worldofpeace worldofpeace mentioned this pull request Dec 31, 2018
Merged
10 tasks
talw added a commit to talw/nixpkgs that referenced this pull request Jan 2, 2019
@talw
dropbox: 55.4.171 -> 63.4.107 (NixOS#53062)
a3410cf 
Dropbox version 55.4.171 is too old which results in an error when doing
the initial account linking.

(cherry picked from commit d5dbfad)
Reason: To have a usable dropbox package for the next release.
worldofpeace pushed a commit that referenced this pull request Jan 2, 2019
@talw @worldofpeace
dropbox: 55.4.171 -> 63.4.107 (#53062)
ce5bbb9 
Dropbox version 55.4.171 is too old which results in an error when doing
the initial account linking.

(cherry picked from commit d5dbfad)
Reason: To have a usable dropbox package for the next release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talw @timokau @GrahamcOfBorg