New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ibus-engines.table: 1.9.20 -> 1.9.21 #53080
Conversation
Needs rebasing |
Is there a practical way to do this with changes to the changelog? |
IMO it makes sense to make these changes separately |
Which changes, and how could they be separate? The update is a fairly major one, which requires the note in the changelog. It doesn't make sense to separate them. |
I took your question to mean that you wanted a way to avoid conflicts. If you insist on keeping the changes in the same commit, there appears to be no way around resolving the conflict, i.e. rebase ... |
Splitting this into two commits isn't going to change the fact that it's vulnerable to conflicts in the release notes. I'd be happy to rebase, but won't that create a new commit each time I do? If the extra commits are fine, I'll just do it. |
The rebase creates a new changeset, so does not entail superflous commits (perhaps you're thinking of merging master into the PR branch?). You will need to force-push the branch after rebasing, however. I generally disagree that you necessarily need to check in both the bump and the changelog to master at the same time. The changelog pertains to the next NixOS release; to my mind, preparing that changelog is a separate concern from ordinary package bumps. If you want to solve the underlying problem of incompatible edits, maybe propose per-package changelogs/warnings or something. Some mechanism for delivering important info pertaining to package updates to end-users apart from the git log would be great (ala |
Aah, okay, I understand what you're intending now. I'll make those changes to this PR shortly... |
35b6db3
to
75f58dc
Compare
Sorry, I didn't test this thoroughly enough. I suggest reverting, unless a quick fix for #56621 can be done. |
@laMudri if a short-term fix turns out to be impossible, please submit a revert PR & I'll be happy to merge it. I suppose it needs to be reverted from the upcoming release branch as well (I've not checked if it's in there) |
Is it just executables (no loadable modules)? Then adding |
@jtojnar It is just executables, but I tried adding |
Is the error still the same? I can see that adding |
Motivation for this change
Regular update, except for the change to config format mentioned in the release notes.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)