Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsForQt5.poppler: fix on darwin #54611

Merged
merged 1 commit into from Jan 28, 2019
Merged

libsForQt5.poppler: fix on darwin #54611

merged 1 commit into from Jan 28, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 26, 2019 •
edited

Motivation for this change

libsForQt5.poppler is broken due to #54606. This provides a workaround to fix the build. Build of poppler was broken due to the same bug, there is a workaround for it. The new workaround should both popplers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Jan 26, 2019
@veprbl veprbl changed the title libsForQt5.popler: fix on darwin libsForQt5.poppler: fix on darwin Jan 26, 2019
@veprbl
Copy link
Member Author

veprbl commented Jan 26, 2019

@GrahamcOfBorg build poppler

@veprbl veprbl merged commit e6f2816 into NixOS:master Jan 28, 2019
@veprbl veprbl deleted the pr/libsForQt5.poppler_fix branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @GrahamcOfBorg