Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtkeychain: remove CMP0025 hack #54612

Merged
merged 1 commit into from Jan 27, 2019
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 26, 2019

Motivation for this change

CMAKE_POLICY_DEFAULT_CMP0025 is already set in cmake setup hook:

cmakeFlags="-DCMAKE_POLICY_DEFAULT_CMP0025=NEW $cmakeFlags"

Also see #54606

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This argument is already set by the cmake setup hook.
@Mic92
Copy link
Member

Mic92 commented Jan 26, 2019

@GrahamcOfBorg build qtkeychain

@infinisil infinisil merged commit e06af14 into NixOS:master Jan 27, 2019
@veprbl veprbl deleted the pr/qtkeychain_cleanup branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants