Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: remove spurious references to compilation flags #54591

Merged
merged 1 commit into from Jan 25, 2019
Merged

neovim: remove spurious references to compilation flags #54591

merged 1 commit into from Jan 25, 2019

Conversation

symphorien
Copy link
Member

Motivation for this change

Neovim used to retain references to compilation flags:

$  nvim --version
NVIM v0.3.1
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /nix/store/nwy73lby94rv8jql92xhxp0wx6gxwjb2-gcc-wrapper-7.3.0/bin/gcc -Wconversion -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=auto -Wno-array-bounds -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/source/build/config -I/build/source/src -I/nix/store/012lvk3fknblpvqdlvvx46yp2s2mpl4v-libuv-1.21.0/include -I/nix/store/dfrq2gx4drrih6b9s5vwawlgn2ld57hj-msgpack-3.0.1/include -I/nix/store/ljlp1wcvrb99iq4cgc01g399ibjfxlib-unibilium-2.0.0/include -I/nix/store/x6547gcsl0grgpb605kmhckaajacj3vw-libtermkey-0.20/include -I/nix/store/nmh18pbxnlh2kdspbphwndwz167hg2aj-neovim-libvterm-2017-11-05/include -I/nix/store/3bz4x4ajkrrxvs6b6iv0lbmwr5rwp08a-jemalloc-5.0.1/include -I/nix/store/f3l058q0zvnzr7nvl0jj789pyvljqadw-glibc-2.27-dev/include -I/build/source/build/src/nvim/auto -I/build/source/build/include
Compilé par nixbld

Features: +acl +iconv +jemalloc +tui 
See ":help feature-compile"

         fichier vimrc système : "$VIM/sysinit.vim"
               $VIM par défaut : "
/nix/store/dvqb2f8gh79bmmss3kwbsgm3bfsz3hrw-neovim-unwrapped-0.3.1/share/nvim"

Run :checkhealth for more info

By removing this, we reduce the closure size from 249672136 to 71369128.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

infinisil
infinisil approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@infinisil infinisil merged commit f3e03ff into NixOS:master Jan 25, 2019
@symphorien symphorien deleted the nvim-refs branch May 18, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
6.topic: closure-size 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @infinisil @GrahamcOfBorg