Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argo: init at 2.2.1 #54601

Merged
merged 1 commit into from Jan 30, 2019
Merged

argo: init at 2.2.1 #54601

merged 1 commit into from Jan 30, 2019

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Jan 26, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 26, 2019

@GrahamcOfBorg build argo

@groodt
Copy link
Contributor Author

groodt commented Jan 27, 2019

Thanks for the review @alyssais

PTAL

@alyssais
Copy link
Member

@GrahamcOfBorg build argo

alyssais
alyssais reviewed Jan 27, 2019
View reviewed changes
pkgs/applications/networking/cluster/argo/default.nix Outdated
goDeps = ./deps.nix;
goPackagePath = "github.com/argoproj/argo";

meta = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most packages will do with lib; here so that they don’t have to repeat lib in this section.

Up to you, but thought I’d mention. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I meant like this:

meta = with lib; {

Top-level imports can make scope confusing and should usually be avoided, but meta is so simple that it’s not an issue there.

@alyssais
Copy link
Member

LGTM. Would you mind squashing your commits (and optionally addressing my comment above)?

@groodt
Copy link
Contributor Author

groodt commented Jan 27, 2019

Thanks @alyssais

Done!

@groodt
Copy link
Contributor Author

groodt commented Jan 28, 2019

PTAL @alyssais

@alyssais alyssais merged commit bfd2c80 into NixOS:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@groodt @Mic92 @alyssais @GrahamcOfBorg