Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bison: 3.2.4 -> 3.3 #54635

Merged
merged 1 commit into from Jan 29, 2019
Merged

bison: 3.2.4 -> 3.3 #54635

merged 1 commit into from Jan 29, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 26, 2019

Motivation for this change

https://lists.gnu.org/archive/html/bison-announce/2019-01/msg00002.html

Have not build-tested it yet, and should at the very least check
Nix still builds with this new version :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill changed the title bison: 3.2.4 -> 3.3 bison: 3.2.4 -> 3.3.1 Jan 27, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Jan 27, 2019

@GrahamcOfBorg build bison nix

@dtzWill
Copy link
Member Author

dtzWill commented Jan 29, 2019

Works for building my systems, looks good!

@dtzWill dtzWill merged commit f235d64 into NixOS:staging Jan 29, 2019
@dtzWill dtzWill deleted the update/bison-3.3 branch January 29, 2019 03:24
@vcunat
Copy link
Member

vcunat commented Jan 29, 2019

Then it's weird that not even glibc builds here: #54870 (comment) (I can reproduce that)

@dtzWill
Copy link
Member Author

dtzWill commented Jan 29, 2019

Then it's weird that not even glibc builds here: #54870 (comment) (I can reproduce that)

That is weird. I thought I must have been mistaken but nope glibc builds fine here, and indeed the glibc for my currently booted system was built w/bison 3.3.1. Strange. Well it may need to be reverted if goes beyond the one issue, sorry about that!

@vcunat
Copy link
Member

vcunat commented Jan 29, 2019

I suppose the breakages won't be too bad. Most of problematic packages should be fixable simply by switching to bison2.

vcunat added a commit that referenced this pull request Jan 29, 2019
@vcunat vcunat changed the title bison: 3.2.4 -> 3.3.1 bison: 3.2.4 -> 3.3 Jan 29, 2019
@dtzWill dtzWill mentioned this pull request Jan 29, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants