Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown menu can set value to a parameter of a different AI #7091

Closed
SamuXarick opened this issue Jan 24, 2019 · 4 comments
Closed

Dropdown menu can set value to a parameter of a different AI #7091

SamuXarick opened this issue Jan 24, 2019 · 4 comments

Comments

@SamuXarick
Copy link
Contributor

SamuXarick commented Jan 24, 2019 •
edited

Requires two AIs. AroAI v127 and LuDiAI AfterFix v7 will serve for this report.

Steps:

  • launch openttd
  • click AI/GS Settings
  • click Select AI
  • select LuDiAI AfterFix and click Accept
  • click Configure
  • click the first parameter, 'Town Cargo' dropdown menu, but don't chose anything yet
  • back to the previous window, click Select AI
  • Select AroAI
  • Before clicking Accept, ensure that 'Town Cargo' dropdown menu is still open
  • After clicking Accept, the list of settings change to the new AI, but the dropdown menu is still open
  • The new first parameter is now 'Enable Road Vehicles' and is shown as enabled.
  • Now click 'Passengers' from the dropdown menu.

BUG: 'Enable Road Vehicles' of AroAI becomes disabled.
@SamuXarick
Copy link
Contributor Author

SamuXarick commented Jan 24, 2019 •
edited

If the AI that is switched to is Random AI, which has no parameters, clicking 'Passengers' will crash OpenTTD, but only if it's a debug build.

SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 24, 2019
@SamuXarick
Fix OpenTTD#7091: Close dropdown menu windows after rebuilding AI/GS …
832dfde 
…settings
@SamuXarick
Copy link
Contributor Author

2019-01-25

@SamuXarick
Copy link
Contributor Author

https://github.com/OpenTTD/OpenTTD/blob/master/src/ai/ai_gui.cpp#L549

@glx22 glx22 mentioned this issue Jan 26, 2019
Closed
@glx22
Copy link
Contributor

glx22 commented Jan 26, 2019

I noticed many problems with missing invalidation in these windows. This issue and #7090 are two of them, but there's also the textfile window and more.

nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
@SamuXarick @nielsmh
Fix OpenTTD#7091: Close dropdown menu windows after rebuilding AI/GS …
3add192 
…settings
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@SamuXarick @douiwby
Fix OpenTTD#7091: Close dropdown menu windows after rebuilding AI/GS …
65d1251 
…settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glx22 @SamuXarick