Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-support: Add Ubuntu bionic base images #54626

Merged
merged 1 commit into from Feb 5, 2019
Merged

build-support: Add Ubuntu bionic base images #54626

merged 1 commit into from Feb 5, 2019

Conversation

FlorianFranzen
Copy link
Contributor

@FlorianFranzen FlorianFranzen commented Jan 26, 2019 •
edited

Motivation for this change

This adds the latest Ubuntu LTS release 18.04 (Bionic Beaver) to set of available VM images.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FlorianFranzen
Copy link
Contributor Author

FlorianFranzen commented Jan 29, 2019 •
edited

To test build the new images just run:

@GrahamcOfBorg build vmTools.diskImages.ubuntu1804i386
@GrahamcOfBorg build vmTools.diskImages.ubuntu1804x86_64

@FlorianFranzen
Copy link
Contributor Author

As there is no official maintainer for this file, I went by git blame: @edolstra or @abbradar, maybe you can take a quick look. Any feedback is welcome.

@edolstra edolstra merged commit dd5aa1a into NixOS:master Feb 5, 2019
@FlorianFranzen FlorianFranzen deleted the bionic branch February 10, 2019 12:18
@FlorianFranzen FlorianFranzen changed the title buid-support: Add Ubuntu bionic base images build-support: Add Ubuntu bionic base images Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FlorianFranzen @edolstra @GrahamcOfBorg