Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: more options for translators #7110

Merged
merged 1 commit into from Jan 26, 2019
Merged

Add: more options for translators #7110

merged 1 commit into from Jan 26, 2019

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Jan 26, 2019

Reusing strings is not bad, but the translation may not fit the context of the string usage.

STR_NEWGRF_SETTINGS_PALETTE_DEFAULT :Default (D)
STR_NEWGRF_SETTINGS_PALETTE_DEFAULT_32BPP :Default (D) / 32 bpp
STR_NEWGRF_SETTINGS_PALETTE_LEGACY :Legacy (W)
STR_NEWGRF_SETTINGS_PALETTE_LEGACY_32BPP :Legacy (W) / 32 bpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"32bpp" ?

Copy link
Contributor Author

@glx22 glx22 Jan 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied strings from source

@@ -2894,8 +2894,13 @@ STR_NEWGRF_SETTINGS_GRF_ID :{BLACK}GRF ID:
STR_NEWGRF_SETTINGS_VERSION :{BLACK}Version: {SILVER}{NUM}
STR_NEWGRF_SETTINGS_MIN_VERSION :{BLACK}Min. compatible version: {SILVER}{NUM}
STR_NEWGRF_SETTINGS_MD5SUM :{BLACK}MD5sum: {SILVER}{RAW_STRING}
STR_NEWGRF_SETTINGS_PALETTE :{BLACK}Palette: {SILVER}{RAW_STRING}
STR_NEWGRF_SETTINGS_PALETTE :{BLACK}Palette: {SILVER}{STRING1}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string has no parameters, so just {STRING}, not {STRING1}

@glx22 glx22 merged commit a18b0eb into OpenTTD:master Jan 26, 2019
@glx22 glx22 deleted the translations branch January 26, 2019 20:17
@glx22 glx22 restored the translations branch January 26, 2019 20:58
@glx22 glx22 deleted the translations branch January 26, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants