Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagemagick: add djvu support #54592

Merged
merged 1 commit into from Feb 6, 2019
Merged

imagemagick: add djvu support #54592

merged 1 commit into from Feb 6, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jan 25, 2019 •
edited

Motivation for this change

This enables support for the DJVU format in ImageMagick.
It is used in gscan2pdf (PR #54434) for instance.

I tested the registration of the library with ImageMagick 6 on NixOS 18.09 and gscan2pdf.
I haven't tested ImageMagick 7 though.

I'm also unsure whether this dependency should be put in propagatedBuildInputs instead of buildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien pacien mentioned this pull request Jan 25, 2019
Merged
10 tasks
veprbl
veprbl reviewed Jan 25, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to look into updating imagemagick_light and imagemagick7_light attributes.

@pacien
Copy link
Contributor Author

pacien commented Jan 25, 2019

You need to look into updating imagemagick_light and imagemagick7_light attributes.

Amended.

@pacien
Copy link
Contributor Author

pacien commented Feb 5, 2019

Up? This blocks #54434.

@veprbl
Copy link
Member

veprbl commented Feb 5, 2019

@GrahamcOfBorg build imagemagick7 imagemagick7_light imagemagick7Big
@GrahamcOfBorg build imagemagick imagemagick_light imagemagickBig

veprbl
veprbl approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review gave no new build failures compared to what's already failing on Hydra

@veprbl veprbl merged commit 87d8ba0 into NixOS:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@memberbetty memberbetty memberbetty approved these changes

@wkennington wkennington Awaiting requested review from wkennington

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacien @veprbl @memberbetty @GrahamcOfBorg