net_snmp: 5.7.3 -> 5.8 #54616
Merged
net_snmp: 5.7.3 -> 5.8 #54616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
commented
Jan 26, 2019
| (fetchAlpinePatch "fix-includes.patch" "0zpkbb6k366qpq4dax5wknwprhwnhighcp402mlm7950d39zfa3m") | ||
| (fetchAlpinePatch "netsnmp-swinst-crash.patch" "0gh164wy6zfiwiszh58fsvr25k0ns14r3099664qykgpmickkqid") | ||
| (fetchAlpinePatch "remove-U64-typedef.patch" "1msxyhcqkvhqa03dwb50288g7f6nbrcd9cs036m9xc8jdgjb8k8j") | ||
| ./CVE-2018-18065.patch | ||
| ./0001-no-network-tests.patch |
There was a problem hiding this comment.
@cyounkins if we are not running the tests, do we even need this patch?
There was a problem hiding this comment.
IMO we should be moving towards enabling the tests. While not necessary right now, I think it makes sense to keep it in for when we touch it next.
There was a problem hiding this comment.
The patch is then essentially dead code, and we can't even be sure the patch works. I'd say let's only introduced patches once we actually need them, and keep builds as simple as possible.
There was a problem hiding this comment.
Especially since the doCheck = false; comment is "Tries to use networking", which suggests that the patch is indeed not doing its job…
10 tasks
This was referenced Mar 8, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
rebased version of #51683
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)