Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query box sets value to hidden parameters #7090

Closed
SamuXarick opened this issue Jan 24, 2019 · 3 comments
Closed

Query box sets value to hidden parameters #7090

SamuXarick opened this issue Jan 24, 2019 · 3 comments

Comments

@SamuXarick
Copy link
Contributor

SamuXarick commented Jan 24, 2019 •
edited

This bug require many steps to reproduce. AIAI v97 will serve as example. It is an AI that has hidden parameters that become visible when ai_developer_tools is on.

Steps:

  • launch openttd
  • start new game
  • open console
  • type in 'startai aiai'
  • type in 'set ai_developer_tools on'
  • open AI/GS Debug window
  • click Settings
  • scroll the bar down to the last parameters
  • open a query box in one of them, for instance, 'no_road_cost' (default value should be 1)
  • before changing the value, type in console 'set ai_developer_tools off'
  • now change the value in the query box (to 123 or so) and click OK
  • back to the console, type in again 'set ai_developer_tools on'
  • scroll down the list of AIAI settings again to the bottom

Bug: 'no_road_cost' was changed to the new value (123)
@SamuXarick
Copy link
Contributor Author

now change the value in the query box (to 123 or so) and click OK

In debug build, clicking OK crashes OpenTTD at this point.

SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 24, 2019
@SamuXarick
Fix OpenTTD#7090: Close Query String window after rebuilding AI/GS se…
1d50e94 
…ttings
@SamuXarick
Copy link
Contributor Author

2019-01-25 3

https://github.com/OpenTTD/OpenTTD/blob/master/src/ai/ai_gui.cpp#L537

@glx22
Copy link
Contributor

glx22 commented Jan 26, 2019

I noticed many problems with missing invalidation in these windows. This issue and #7091 are two of them, but there's also the textfile window and more.

@glx22 glx22 mentioned this issue Jan 26, 2019
Closed
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 20, 2019
@SamuXarick
Fix OpenTTD#7090: Close Query String window after rebuilding AI/GS se…
292a517 
…ttings
@glx22 glx22 closed this as completed in 66d23e3 Feb 21, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
@SamuXarick @nielsmh
Fix OpenTTD#7090: Close Query String window after rebuilding AI/GS se…
06509fc 
…ttings
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@SamuXarick @douiwby
Fix OpenTTD#7090: Close Query String window after rebuilding AI/GS se…
50a9dd6 
…ttings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glx22 @SamuXarick