Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon-ecr-credential-helper: 0.1.0 -> 0.3.0 #54607

Merged

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Jan 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@groodt
Copy link
Contributor Author

groodt commented Jan 26, 2019

cc @kalbasit

@Mic92
Copy link
Member

Mic92 commented Jan 26, 2019

@GrahamcOfBorg build amazon-ecr-credential-helper

@kalbasit kalbasit merged commit b1ddb5f into NixOS:master Jan 26, 2019
@worldofpeace
Copy link
Contributor

This commit message didn't match the contribution guidelines.
However the pr title did.

In the future @groodt make sure you're sensitive to that detail, even if it gets merged accidentally.

@kalbasit
Copy link
Member

oh oops, I should have squahed the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants