Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gambit and gerbil from upstream #54632

Merged
merged 6 commits into from Jan 28, 2019
Merged

Update gambit and gerbil from upstream #54632

merged 6 commits into from Jan 28, 2019

Conversation

fare
Copy link
Contributor

@fare fare commented Jan 26, 2019

Motivation for this change

New upstream releases.
A few packaging improvements (download less for gambit, statically link gambit path into gerbil).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fare
Copy link
Contributor Author

fare commented Jan 26, 2019

(Weird that github sorts the commits by inception date and not by order in the history, which is different due to rebases)

@fare
Copy link
Contributor Author

fare commented Jan 26, 2019

@thoughtpolice @7c6f434c

@grahamc
Copy link
Member

grahamc commented Jan 26, 2019

Weird that only fare is listed as a maintainer in https://gist.github.com/GrahamcOfBorg/5eca118b37e498583e34a08c76c7be59 ... hmm...

@7c6f434c
Copy link
Member

@GrahamcOfBorg build gerbil gambit gerbil-unstable gambit-unstable

@grahamc nothing too strange: the gerbil file (where there is a single maintainer) got changed, the gambit package definition didn't really — only the source-tarball definition files did. This is probably similar enough to all-packages.nix situation for ofborg not to mention me.

@7c6f434c 7c6f434c merged commit 545cbf1 into NixOS:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fare @grahamc @7c6f434c @GrahamcOfBorg