Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.coq-extensible-records: init at 1.2.0 #54602

Merged
merged 1 commit into from Jan 30, 2019
Merged

coqPackages.coq-extensible-records: init at 1.2.0 #54602

merged 1 commit into from Jan 30, 2019

Conversation

Ptival
Copy link
Contributor

@Ptival Ptival commented Jan 26, 2019

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jan 26, 2019

@GrahamcOfBorg eval

@vbgl
Copy link
Contributor

vbgl commented Jan 29, 2019

@GrahamcOfBorg build coqPackages.coq-extensible-records

@vbgl
Copy link
Contributor

vbgl commented Jan 30, 2019

@GrahamcOfBorg build coqPackages.coq-extensible-records

@vbgl vbgl merged commit f5dbe5d into NixOS:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memberbetty memberbetty memberbetty left review comments

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
6.topic: coq 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ptival @grahamc @vbgl @memberbetty @GrahamcOfBorg