Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numix-icon-theme-{circle,square}: 18.09.19 -> 19.01.24 #54604

Merged
merged 2 commits into from Jan 26, 2019
Merged

numix-icon-theme-{circle,square}: 18.09.19 -> 19.01.24 #54604

merged 2 commits into from Jan 26, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 26, 2019

Motivation for this change
  • numix-icon-theme-circle: 18.09.19 -> 19.01.24
  • numix-icon-theme-square: 18.09.19 -> 19.01.24
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jan 26, 2019

@GrahamcOfBorg eval

@worldofpeace worldofpeace merged commit 409f9d1 into NixOS:master Jan 26, 2019
@romildo romildo deleted the upd.numix-icon-theme-circle branch January 26, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@jgeerds jgeerds Awaiting requested review from jgeerds

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @grahamc @worldofpeace @GrahamcOfBorg