Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netsurf: 3.5 -> 3.8 #54610

Closed
wants to merge 13 commits into from
Closed

netsurf: 3.5 -> 3.8 #54610

wants to merge 13 commits into from

Conversation

samueldr
Copy link
Member

Motivation for this change

Updates netsurf and related libraries.

The default config for netsurf (using sixel ui) wasn't tested, I can't get it to work, in the previous iteration either. The gtk ui, though works fine.

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • 🔲 macOS
    • 🔲 other Linux distributions
  • 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ✔️ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ✔️ Tested execution of all binary files (usually in ./result/bin/)
  • 🔲 Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Assured whether relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 26, 2019

@GrahamcOfBorg build netsurf

@mmahut
Copy link
Member

mmahut commented May 19, 2019

@GrahamcOfBorg build netsurf

@fgaz
Copy link
Member

fgaz commented Jul 2, 2019 •
edited

Ping :)

What is the status of this? Does it need more testing?

@samueldr
Copy link
Member Author

samueldr commented Jul 3, 2019

It has some issues, but fewer than the previous version:

Tried to load up GitHub:

image

I had some (4) with nixos.org, but see, it works...

image

This is an improvement to the current behaviour of not working after showing empty windows.

image

So... erm I'm not sure it was acting that way back in January. Not sure where to go from here.

@S-NA
Copy link
Contributor

S-NA commented Jul 3, 2019

According to the Netsurf mailing list, the last call for fixes to land in 3.9 is happening now. The version is expected to fix a lot of issues. Including incompatibilities with newer versions of cURL which I encounter when running Netsurf using this PR.

I have an environment with nix-shell for developing Netsurf and the build it produces seems to work with no issues. Maybe merge this and make a note to update to the 3.9 release soon or perhaps wait, since the release is not too far off. That said feedback is requested against their CI builds.

@S-NA S-NA mentioned this pull request Jul 3, 2019
Closed
@fgaz
Copy link
Member

fgaz commented Jul 3, 2019

+1 for merging this for now and seeing what happens with 3.9 once it's released

@samueldr
Copy link
Member Author

samueldr commented Jul 3, 2019

Let's wait; no change here is worth it since it's likely close; 3.9 is likely to fix the issue if I understand it right.

@samueldr
Copy link
Member Author

Turns out the update didn't fix the issue with the certificates being unknown, but I figured out a solution to the problem. See #65360.

@samueldr samueldr closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@samueldr @Mic92 @mmahut @fgaz @S-NA @infinisil @GrahamcOfBorg