Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.scrapy: fix build on Python 3.7 #52719

Merged
merged 1 commit into from Dec 23, 2018
Merged

pythonPackages.scrapy: fix build on Python 3.7 #52719

merged 1 commit into from Dec 23, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 23, 2018

Motivation for this change

Fixes #52229

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner December 23, 2018 03:27
@Ma27
Copy link
Member

Ma27 commented Dec 23, 2018

Built and tested locally. The Python2 build occurs because of a broken dependency (see also https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.python27Packages.scrapy.x86_64-linux).

Just to be sure, let's build this with ofBorg as well.

@GrahamcOfBorg test python37Packages.scrapy

@Ma27
Copy link
Member

Ma27 commented Dec 23, 2018

ah, my mistake...

@GrahamcOfBorg build python37Packages.scrapy

@Ma27 Ma27 merged commit db5399b into NixOS:master Dec 23, 2018
@Ma27
Copy link
Member

Ma27 commented Dec 23, 2018

@marsam thanks!

@marsam marsam deleted the fix-scrapy-python37 branch December 23, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @Ma27 @GrahamcOfBorg