Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes eval issues in hydra by setting AArch64 as limited support #52721

Merged
merged 2 commits into from Dec 23, 2018
Merged

Fixes eval issues in hydra by setting AArch64 as limited support #52721

merged 2 commits into from Dec 23, 2018

Conversation

samueldr
Copy link
Member

Motivation for this change

nixos/release-combined.nix: Adds missing aarch64 constituents

This will block channel advancing, even if it is limited support.

nixos/release-combined.nix: makes aarch64-linux limited support

This is because it will not eval properly with hydra-eval-jobs.

$ ...hydra/result/bin/hydra-eval-jobs \
    --arg nixpkgs '{ outPath = ./.; revCount = 123; shortRev = "4567"; }' \
    -I "$PWD" \
    nixos/release-combined.nix

It fails with:

Too many heap sections: Increase MAXHINCR or MAX_HEAP_SECTS

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samueldr
nixos/release-combined.nix: Adds missing aarch64 constituents
16316a1 
This will block channel advancing, even if it is limited support.
@samueldr
nixos/release-combined.nix: makes aarch64-linux limited support
1bfe8f1 
This is because it will not eval properly with `hydra-eval-jobs`.

```
$ ...hydra/result/bin/hydra-eval-jobs \
    --arg nixpkgs '{ outPath = ./.; revCount = 123; shortRev = "4567"; }' \
    -I "$PWD" \
    nixos/release-combined.nix
```

It fails with:

```
Too many heap sections: Increase MAXHINCR or MAX_HEAP_SECTS
```
@samueldr samueldr changed the title Aarch64/limited support Fixes eval issues in hydra by setting AArch64 as limited support Dec 23, 2018
@samueldr samueldr merged commit 7727591 into NixOS:master Dec 23, 2018
@vcunat
Copy link
Member

vcunat commented Dec 25, 2018

Hmm, sd_image for aarch64 is using linuxPackages_latest, and that's still blocking now due to zfs being used by default and not updated to support the newest kernel yet. @dezgeg (author of that): perhaps it would be easier to maintain if switched to 4.19? BTW, I assume it's about time to consider switching the default kernel to 4.19 anyway.

@samueldr
Copy link
Member Author

Maybe we need to do the same thing, stick to "current LTS" for the blocker SD image (which soon should be 4.19 anyway) and also provide a non-blocking sd_image_new_kernel.

This was referenced Dec 25, 2018
Merged
Merged
@samueldr samueldr deleted the aarch64/limited-support branch February 12, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samueldr @vcunat @GrahamcOfBorg