Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove paxutils #52661

Closed
wants to merge 1 commit into from
Closed

treewide: remove paxutils #52661

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 22, 2018

More then one year ago we removed grsecurity kernels from nixpkgs:
#25277

This removes now also paxutils from stdenv.
I will move this to staging soon.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@joachifm joachifm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can infer that nobody cares about nixpkgs on grsec/pax ...

@@ -15023,12 +15023,6 @@ in

pam_usb = callPackage ../os-specific/linux/pam_usb { };

paxctl = callPackage ../os-specific/linux/paxctl { };

paxtest = callPackage ../os-specific/linux/paxtest { };
Copy link
Contributor

@joachifm joachifm Dec 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that leaving at least paxtest and maybe even paxctl makes sense; the former can be used to assess whether vanilla mitigations are able to catch stuff covered by PaX, which I find useful (given the ongoing effort to backport/lift features from grsec/pax).

More then one year ago we removed grsecurity kernels from nixpkgs:
NixOS#25277

This removes now also paxutils from stdenv.
@Mic92
Copy link
Member Author

Mic92 commented Dec 22, 2018

cherry-picked to staging in 1b146a8

@Mic92 Mic92 closed this Dec 22, 2018
@Mic92 Mic92 deleted the pax branch December 22, 2018 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants