nixos/displayManager: only install wayland sessions if they exist in … #52660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extraSessionFilePackages Not everyone is using wayland just yet.
jtojnar
reviewed
Jan 3, 2019
| ${concatMapStrings (pkg: '' | ||
| ${xorg.lndir}/bin/lndir ${pkg}/share/wayland-sessions $out/share/wayland-sessions | ||
| if test -d ${pkg}/share/wayland-sessions; then | ||
| mkdir -p "$out/share/wayland-sessions" |
There was a problem hiding this comment.
Why are we creating the directory? Should not lndir already do that?
There was a problem hiding this comment.
Nope, looks like lndir fromdir todir will fail if todir doesn't exist already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Was using
extraSessionFilePackagesin #48637 and I couldn't rebuild because it was trying to link a nonexistant directory.That's because elementary doesn't have a wayland session.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)