Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "neopg: 0.0.4 -> 0.0.5" #52740

Merged
merged 1 commit into from Dec 23, 2018
Merged

Revert "neopg: 0.0.4 -> 0.0.5" #52740

merged 1 commit into from Dec 23, 2018

Conversation

erictapen
Copy link
Member

This broke the build, as the bump introduced test failures. Revert to a
working version.

I'm aware of the problem, but haven't found a solution to it yet.

@schneefux Could you please test the build before bumping the package? Also a mention of the package maintainer (in this case me) would have been nice (but not necessary imho).

Thanks to @Mic92, who just informed me in #37700 about the breakage.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
Revert "neopg: 0.0.4 -> 0.0.5"
35b6b89 
This broke the build, as the bump introduced test failures. Revert to a
working version.

This reverts commit 0317371.
@erictapen
Copy link
Member Author

@GrahamcOfBorg build neopg

@Mic92 Mic92 merged commit e5533ff into NixOS:master Dec 23, 2018
@erictapen erictapen deleted the neopg-revert branch December 23, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @Mic92 @GrahamcOfBorg