Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyaxmlparser: fix build #52742

Merged
merged 1 commit into from Dec 23, 2018
Merged

python3Packages.pyaxmlparser: fix build #52742

merged 1 commit into from Dec 23, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 23, 2018 •
edited

Motivation for this change

The build is currently broken on master[1] due to a major bump of
click in fe0af1c.

Manually patching setup.py temporarily fixes the issue. To ensure that
succeeding builds don't deliver packages breaking at runtime due to
dependency issues I switched to the GitHub archive as source since it
contains tests as well.

Additionally, Python 2.7 support has been dropped. It seems as it
was never intended to support Python3 here, I simply forgot to disable
the Python2 build:

TypeError: AXMLParser object is not an iterator

[1] https://hydra.nixos.org/build/86108813

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner December 23, 2018 22:06
@Ma27
python3Packages.pyaxmlparser: fix build
30c6234 
The build is currently broken on master[1] due to a major bump of
`click` in fe0af1c.

Manually patching `setup.py` temporarily fixes the issue. To ensure that
succeeding builds don't deliver packages breaking at runtime due to
dependency issues I switched to the GitHub archive as source since it
contains tests as well.

Additionally, Python 2.7 support has been dropped. It seems as it
was never intended to support Python3 here, I simply forgot to disable
the Python2 build.

```
TypeError: AXMLParser object is not an iterator
```

[1] https://hydra.nixos.org/build/86108813
@Ma27
Copy link
Member Author

Ma27 commented Dec 23, 2018

@Mic92 thanks for the review, fixed! :)

@Ma27 Ma27 closed this Dec 23, 2018
@Ma27 Ma27 reopened this Dec 23, 2018
@Mic92 Mic92 merged commit 75436c9 into NixOS:master Dec 23, 2018
@Ma27 Ma27 deleted the fix-pyaxmlparser branch December 23, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @Mic92 @GrahamcOfBorg