pythonPackages: trezor: 0.10.2 -> 0.11.1 #52741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Dec 24, 2018
prusnak
force-pushed
the
python-trezor
branch
from
a21e5c0
to
9151281
Compare
|
Don't merge yet, I'll amend the PR to update to upcoming 0.11.1 |
prusnak
force-pushed
the
python-trezor
branch
2 times, most recently
from
68281ae
to
66b17f1
Compare
prusnak
changed the title
|
Amended. Good to merge. |
|
@dotlambda Can you please help with the build failure? I think this is a false positive. |
jb55
approved these changes
Jan 9, 2019
dotlambda
reviewed
Jan 10, 2019
|
@GrahamcOfBorg eval |
prusnak
force-pushed
the
python-trezor
branch
from
66b17f1
to
c220f4c
Compare
|
@dotlambda addressed your comments in c220f4c, thanks for the hints! |
|
ping @FRidh |
dotlambda
reviewed
Jan 23, 2019
|
|
||
| # build requires UTF-8 locale | ||
| LANG = "en_US.UTF-8"; | ||
| LOCALE_ARCHIVE = "${glibcLocales}/lib/locale/locale-archive"; |
There was a problem hiding this comment.
Is LOCaLE_ARCHIVE still required?
There was a problem hiding this comment.
Not for master, I can even remove glibcLocales from nativeBuildInputs
When I backport this patch to release-18.09 branch I need to keep glibcLocales in nativeBuildInputs but the line with LOCALE_ARCHIVE can go away.
There was a problem hiding this comment.
Any reason for this to be backported?
There was a problem hiding this comment.
Couple of them:
- we add a lot of features into Trezor and these are not accessible if a user has an older version of python-trezor leading to frustration
- I assume NixPkgs Electrum maintainers don't backport security patches individually, but rather the whole package is being updated to the newest stable release. This release might already be depending on the new python-trezor package, using the new API, etc. so it makes sense to upgrade the whole package for python-trezor too.
prusnak
force-pushed
the
python-trezor
branch
from
c220f4c
to
bdb81a8
Compare
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version update
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)