rmlint: 2.6.1 -> 2.8.0 #52738
Merged
rmlint: 2.6.1 -> 2.8.0 #52738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recipe now uses the default scons build phases.
Mic92
reviewed
Dec 23, 2018
|
@GrahamcOfBorg build rmlint |
|
@Mic92 Anything missing to get this merged? |
Mic92
reviewed
Jan 24, 2019
| }; | ||
|
|
||
| configurePhase = "scons config"; | ||
| CFLAGS="-I${stdenv.lib.getDev utillinux}/include"; |
There was a problem hiding this comment.
Does scons suspress our $NIX_CFLAGS_COMPILE variable? because adding utillinux to buildInputs will have the very same effect?
There was a problem hiding this comment.
Mhm. I added this patch myself :). So this probably not the case.
|
@GrahamcOfBorg build rmlint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest version.
The recipe now uses the default scons build phases.
If somebody has a hint on how to get rid of the ugli patch hack I would be glad to hear it.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)