Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gogs, gitea: add PAM support #52714

Merged
merged 2 commits into from Mar 6, 2019
Merged

gogs, gitea: add PAM support #52714

merged 2 commits into from Mar 6, 2019

Conversation

furrycatherder
Copy link
Contributor

@furrycatherder furrycatherder commented Dec 23, 2018 •
edited

Motivation for this change

PR adds the "pam" tag to gitea and gogs go builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@furrycatherder furrycatherder changed the title Gitea pam gogs, gitea: add PAM support Dec 23, 2018
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/9

@matthewbauer
Copy link
Member

@GrahamcOfBorg build gogs gitea

@aanderse
Copy link
Member

aanderse commented Mar 6, 2019

The error log on aarch64-linux looks funky... once more, just for good measure...

@GrahamcOfBorg build gogs gitea

@aanderse
Copy link
Member

aanderse commented Mar 6, 2019 •
edited

@GrahamcOfBorg test gitea.mysql

aanderse
aanderse approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matthewbauer feel like merging when you have some time? 😄

@matthewbauer matthewbauer merged commit 5bc72b8 into NixOS:master Mar 6, 2019
@matthewbauer
Copy link
Member

Yeah looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@furrycatherder @nixos-discourse @matthewbauer @aanderse @GrahamcOfBorg