Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the implicit constructor for AccuracyParameters #2034

Merged
merged 5 commits into from
Dec 23, 2018

Conversation

eggrobin
Copy link
Member

Use 0x1p-24 in most places; this should make the tests (and benchmarks, etc.) a bit faster, and most importantly prevent them from becoming massively slower with #2032.

@@ -123,7 +123,8 @@ void BM_EphemerisKSPSystem(benchmark::State& state) {
astronomy::StabilizeKSP(*at_origin);
Instant const final_time = at_origin->epoch() + 100 * JulianYear;
auto const ephemeris = at_origin->MakeEphemeris(
FittingTolerance(state.range(0)),
/*accuracy_parameters=*/{FittingTolerance(state.range(0)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the function FittingTolerance by a function MakeAccuracyParameters that sets both parameters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this doesn't really work well because of the existing MakeAccuracyParameters in this file that would still need FittingTolerance.

@pleroy pleroy added the LGTM label Dec 22, 2018
@eggrobin
Copy link
Member Author

retest this please

Sorry, something went wrong.

@eggrobin eggrobin force-pushed the no-implicit-constructor branch from 778029a to 90fe847 Compare December 23, 2018 14:00
@eggrobin eggrobin merged commit 16d3417 into mockingbirdnest:master Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants