Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cli-helpers: fix missing dependencies #52692

Merged
merged 1 commit into from Dec 23, 2018
Merged

pythonPackages.cli-helpers: fix missing dependencies #52692

merged 1 commit into from Dec 23, 2018

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Dec 22, 2018

Motivation for this change

I tried to update pgcli and noticed that cli-helpers were not being built, e.g.

Collecting configobj>=5.0.5 (from cli-helpers==1.1.0)
  Could not find a version that satisfies the requirement configobj>=5.0.5 (from cli-helpers==1.1.0) (from versions: )
No matching distribution found for configobj>=5.0.5 (from cli-helpers==1.1.0)
builder for '/nix/store/85x4157vczhfkfi1dcsvka68zkhsi9cw-python3.7-cli_helpers-1.1.0.drv' failed with exit code 1

This commit introduces two new dependencies for this package, configobj and mock. I have tested the modified package against pgcli.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jokogr jokogr requested a review from FRidh as a code owner December 22, 2018 17:17
@dotlambda dotlambda changed the title cli-helpers: fix missing dependencies pythonPackages.cli-helpers: fix missing dependencies Dec 22, 2018
dotlambda
dotlambda reviewed Dec 22, 2018
View reviewed changes
pkgs/development/python-modules/cli-helpers/default.nix
@@ -19,12 +21,13 @@ buildPythonPackage rec {
};

propagatedBuildInputs = [
configobj
terminaltables
tabulate
wcwidth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to no longer be a dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the initial failure as I have indicated in motivation.

Even in master (e.g. 3d5025b) there is currently a reproducible failure:

git clone https://github.com/NixOS/nixpkgs
cd nixpkgs
nix-build -E 'with import ./. { }; pgcli'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotlambda it's in install_requires

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant wcwidth. I can't find wcwidth in https://github.com/dbcli/cli_helpers/blob/v1.1.0/setup.py#L41-L45.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotlambda sorry, I thought you were commenting the change, not just the last line.

I have tried removing wcwidth and I get the following error:

Collecting wcwidth; extra == "widechars" (from tabulate[widechars]>=0.8.2->cli-helpers==1.1.0)
  Could not find a version that satisfies the requirement wcwidth; extra == "widechars" (from tabulate[widechars]>=0.8.2->cli-helpers==1.1.0) (from versions: )
No matching distribution found for wcwidth; extra == "widechars" (from tabulate[widechars]>=0.8.2->cli-helpers==1.1.0)
builder for '/nix/store/18wzsymnny12jm8vyc930fhbzkpr7qg8-python3.7-cli_helpers-1.1.0.drv' failed with exit code 1

Seems to me as a propagated dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, then it's good.

dotlambda
dotlambda reviewed Dec 22, 2018
View reviewed changes
pkgs/development/python-modules/cli-helpers/default.nix
@@ -1,11 +1,13 @@
{ lib
, buildPythonPackage
, fetchPypi
, configobj
, terminaltables
, tabulate
, backports_csv
, wcwidth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this is much needed.

@FRidh
Copy link
Member

FRidh commented Dec 23, 2018

@GrahamcOfBorg eval

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.cli-helpers python3.pkgs.cli-helpers

@dotlambda dotlambda merged commit 7cb9827 into NixOS:master Dec 23, 2018
@jokogr jokogr deleted the f/cli-helpers branch December 25, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jokogr @FRidh @dotlambda @GrahamcOfBorg