Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poppler: 0.67.0 → 0.72.0 #52715

Merged
merged 5 commits into from Dec 25, 2018
Merged

poppler: 0.67.0 → 0.72.0 #52715

merged 5 commits into from Dec 25, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 23, 2018 •
edited

Motivation for this change

https://gitlab.freedesktop.org/poppler/poppler/blob/poppler-0.72.0/NEWS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @codyopel @ttuegel

@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 23, 2018

cc @layus https://github.com/OpenPrinting/cups-filters/blob/release-1-21-6/NEWS

@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 23, 2018

cc @vcunat @lovek323 @raskin @jwiegley for the texlive.bin.core change.

@jtojnar jtojnar changed the base branch from master to staging December 23, 2018 02:11
layus
layus approved these changes Dec 24, 2018
View reviewed changes
Copy link
Member

@layus layus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcunat
texlive.bin.core-big: use postPatch from .core
e16ec29 
Otherwise it wouldn't build with new poppler either.
(Perhaps not all of it is needed here, but why not apply it all?)
vcunat
vcunat approved these changes Dec 25, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all of texlive binaries build OK, and the changes seem reasonable. I haven't tested anything, though.

@jtojnar jtojnar merged commit 4c5a5dc into NixOS:staging Dec 25, 2018
@jtojnar jtojnar deleted the poppler-0.72 branch December 25, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layus layus layus approved these changes

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: freedesktop 6.topic: printing 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @layus @vcunat @GrahamcOfBorg