Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flexget: 2.17.14 -> 2.17.20 #52681

Merged
merged 1 commit into from Dec 23, 2018
Merged

flexget: 2.17.14 -> 2.17.20 #52681

merged 1 commit into from Dec 23, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

closes #52529

I have removed some entries from propagatedBuildInputs that can't be found in https://github.com/Flexget/Flexget/blob/2.17.20/requirements.in. However, I'm not sure whether they're just some optional requirements and should be added back.

The delugeSupport argument has been removed as deluge support is handled by the deluge-client library which we can always install.

I did not test this thoroughly because I'm not a Flexget user. Feel free to do so in my place.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @sjau

@dotlambda dotlambda mentioned this pull request Dec 22, 2018
Closed
10 tasks
@sjau
Copy link

sjau commented Dec 22, 2018

This works for me.

@dotlambda
Copy link
Member Author

Note that I'm using Python 3.7 even though upstream does not officially support this. However, using 3.6 will produce more load on Hydra so I suggest keeping it like that until someone complains.

@sjau
Copy link

sjau commented Dec 23, 2018

Actually I was too quick... it crashes.

2018-12-23 08:00 DEBUG    manager                       Figuring out config load paths
2018-12-23 08:00 DEBUG    manager                       Found config: /.../.flexget/config.yml
2018-12-23 08:00 DEBUG    manager                       Config file /.../.flexget/config.yml selected
2018-12-23 08:00 CRITICAL task          tv_feeds_lq     BUG: Unhandled error in plugin series: bad escape \w at position 5
Traceback (most recent call last):
  File "/nix/store/9vcy8i7mcwmcp486krc22v7851spcdqj-python3-3.7.1/lib/python3.7/sre_parse.py", line 1021, in parse_template
    this = chr(ESCAPES[this][1])
KeyError: '\\w'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/nix/store/0kn8ifx9827h58hbkkf4kpna2w3j7gam-FlexGet-2.17.20/lib/python3.7/site-packages/flexget/task.py", line 486, in __run_plugin
    return method(*args, **kwargs)
  File "/nix/store/0kn8ifx9827h58hbkkf4kpna2w3j7gam-FlexGet-2.17.20/lib/python3.7/site-packages/flexget/event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "/nix/store/0kn8ifx9827h58hbkkf4kpna2w3j7gam-FlexGet-2.17.20/lib/python3.7/site-packages/flexget/plugins/filter/series.py", line 1621, in on_task_metainfo
    parsed = parser.parse_series(entry['title'])
  File "/nix/store/0kn8ifx9827h58hbkkf4kpna2w3j7gam-FlexGet-2.17.20/lib/python3.7/site-packages/flexget/plugins/parsers/plugin_parsing.py", line 74, in parse_series
    return parser.parse_series(data, name=name, **kwargs)
  File "/nix/store/0kn8ifx9827h58hbkkf4kpna2w3j7gam-FlexGet-2.17.20/lib/python3.7/site-packages/flexget/plugins/parsers/parser_internal.py", line 54, in parse_series
    parser.parse(data)
  File "/nix/store/0kn8ifx9827h58hbkkf4kpna2w3j7gam-FlexGet-2.17.20/lib/python3.7/site-packages/flexget/utils/titles/series.py", line 225, in parse
    name_to_re(name, self.ignore_prefixes, self) for name in [self.name] + self.alternate_names)
  File "/nix/store/0kn8ifx9827h58hbkkf4kpna2w3j7gam-FlexGet-2.17.20/lib/python3.7/site-packages/flexget/utils/tools.py", line 205, in __init__
    list.__init__(self, *args, **kwargs)
  File "/nix/store/0kn8ifx9827h58hbkkf4kpna2w3j7gam-FlexGet-2.17.20/lib/python3.7/site-packages/flexget/utils/titles/series.py", line 225, in <genexpr>
    name_to_re(name, self.ignore_prefixes, self) for name in [self.name] + self.alternate_names)
  File "/nix/store/0kn8ifx9827h58hbkkf4kpna2w3j7gam-FlexGet-2.17.20/lib/python3.7/site-packages/flexget/plugins/parsers/parser_common.py", line 85, in name_to_re
    res = re.sub(' +', blank + '*', res, re.UNICODE)
  File "/nix/store/9vcy8i7mcwmcp486krc22v7851spcdqj-python3-3.7.1/lib/python3.7/re.py", line 192, in sub
    return _compile(pattern, flags).sub(repl, string, count)
  File "/nix/store/9vcy8i7mcwmcp486krc22v7851spcdqj-python3-3.7.1/lib/python3.7/re.py", line 309, in _subx
    template = _compile_repl(template, pattern)
  File "/nix/store/9vcy8i7mcwmcp486krc22v7851spcdqj-python3-3.7.1/lib/python3.7/re.py", line 300, in _compile_repl
    return sre_parse.parse_template(repl, pattern)
  File "/nix/store/9vcy8i7mcwmcp486krc22v7851spcdqj-python3-3.7.1/lib/python3.7/sre_parse.py", line 1024, in parse_template
    raise s.error('bad escape %s' % this, len(this))
re.error: bad escape \w at position 5

@dotlambda
Copy link
Member Author

Can this crash be prevented by replacing python3 by python36?

@sjau
Copy link

sjau commented Dec 23, 2018

Testing it

@sjau
Copy link

sjau commented Dec 23, 2018

no crash with 3.6

@dotlambda dotlambda merged commit 0c75ad7 into NixOS:master Dec 23, 2018
@agentpt5
Copy link
Contributor

agentpt5 commented Jan 3, 2019

Thanks for maintaining Flexget. Works after adding
pkgs.python36Packages.transmissionrpc to propagatedBuildInputs

@dotlambda
Copy link
Member Author

Works after adding pkgs.python36Packages.transmissionrpc to propagatedBuildInputs

Do you mind opening a PR for that?

@agentpt5
Copy link
Contributor

agentpt5 commented Jan 9, 2019

Works after adding pkgs.python36Packages.transmissionrpc to propagatedBuildInputs

Do you mind opening a PR for that?

I can do whatever you think is best. I need to add back transmissionrpc, because I use transmission instead of deluge.

@agentpt5
Copy link
Contributor

I created pull request - Flexget 2.17.20: add transmissionrpc as dependency #53735

@dotlambda dotlambda deleted the flexget-2.17.20 branch April 1, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @sjau @agentpt5 @GrahamcOfBorg