Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sfml build on Darwin #52705

Merged
merged 3 commits into from Jan 3, 2019
Merged

Fix sfml build on Darwin #52705

merged 3 commits into from Jan 3, 2019

Conversation

jacereda
Copy link
Contributor

@jacereda jacereda commented Dec 22, 2018 •
edited

Motivation for this change

Building sfml fails on Darwin at link stage:

[ 48%] Linking CXX shared library ../../../lib/libsfml-window.dylib
Undefined symbols for architecture x86_64:
  "_NSDefaultRunLoopMode", referenced from:
      +[SFApplication processEvent] in SFApplication.m.o
  "_OBJC_CLASS_$_NSArray", referenced from:
      objc-class-ref in ClipboardImpl.mm.o
      objc-class-ref in SFOpenGLView+keyboard.mm.o
  "_OBJC_CLASS_$_NSDate", referenced from:
      objc-class-ref in SFApplication.m.o
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [src/SFML/Window/CMakeFiles/sfml-window.dir/build.make:655: lib/libsfml-window.2.5.1.dylib] Error 1
make[1]: *** [CMakeFiles/Makefile2:176: src/SFML/Window/CMakeFiles/sfml-window.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

LnL7
LnL7 approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit d0f4baf into NixOS:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacereda @LnL7 @GrahamcOfBorg @Janik-Haag