Palemoon 28.3.0 (from binary tarball) #52728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested the binary? Because it doesn't work for me. I'm not sure myself how |
|
Maybe try Also why the |
| cat "$src" | tar xj | ||
| ''; | ||
|
|
||
| buildPhase = ":"; # nothing to build |
There was a problem hiding this comment.
Can't we do dontBuild = true;?
Binaries get patched already during build, this is the output in my system:
This is required to get only |
Unfortunately this is not that simple, though I wish it was. I recommend giving https://nixos.wiki/wiki/Packaging/Binaries a read and possibly anything to do with patching binaries like this under nix. |
develCuy
changed the title
|
@develCuy I've noticed that you've been updating this but you haven't made the requested changes. These binaries won't work because they aren't patched. Please see my comment at #52728 (comment) or ask in #nixos on freenode if you need further guidance. |
|
Palemoon has been updated from source #64499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Easy install palemoon 28.3.0 (currently the latest release), which includes security updates. The build from sources is currently broken (see #51161).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)